Fixissue876 - #931
Merged
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Skeleton loading placeholders were implemented three inconsistent ways across the codebase:
ui/Skeleton.tsxusedanimate-pulse bg-gray-200 dark:bg-gray-700dashboard/dashboard-view.tsxhad a customSkeletonCardwith a CSS shimmer animation (animate-[shimmer_1.4s_infinite]) andbg-white/5wallet/WalletButton.tsxused a dedicated.wallet-btn-skeletonCSS classStreamListSkeletonwas exported fromSkeleton.tsxbut never imported anywhereType of Change
Related Issues
Closes #876
Changes Made
ui/Skeleton.tsx: Removed deadStreamListSkeletonexport (unreferenced in any component)dashboard/dashboard-view.tsx: Replaced customSkeletonCardshimmer implementation with the sharedSkeletoncomponent. Added import from@/components/ui/Skeletonwallet/WalletButton.tsx: Replacedwallet-btn-skeletonCSS class with shared<Skeleton className="w-[140px] h-[2.4rem] rounded-full" />. Added import from@/components/ui/SkeletonTesting
Test Coverage
Test Steps
animate-pulseanimation and gray color scheme/incoming— verify skeleton cards are visually consistent with dashboard skeletonsChecklist
Additional Notes
No breaking changes. The
.wallet-btn-skeletonCSS class inglobals.cssremains as dead CSS (out of scope for this change). The incoming page'sLoadingCardalready used the sharedSkeletoncomponent and required no changes.